-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facility image issue is Fixed #8744
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👋 Hi, @NikhilGolla72, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@NikhilGolla72 Adding it to staff capacity is not bringing any value to the users, so closing this PR, as this is an irrelevant change, feel free to work on any open issues in the care_fe |
@NikhilGolla72 Sorry for the inconvenience, bro, but make sure you link an issue(#7297) to your PR so that, during the review, we can see which issue you're trying to address. The PR heading is not clearly communicating what the PR is about. Could you make the following changes: :
|
@nihal467 sorry for the misunderstanding I caused,I am new to the open source contribution and I didn't know the fomat to submit a PR.I will follow the format from now on for sure and also I will make it as a 4th step and also I want to ask about the cypress attempt 2 which is caused by not identifying the " div#map-close " under 10000ms .Can I change it 20000ms to that it may be solve this cypress test issue? |
@NikhilGolla72 can you share the screenshot of the cypress dashboard , to know what is exactly |
@NikhilGolla72 run the cypress locally and try to debug it, use the command "npx cypress open" and check whether its passing in your local to not |
@nihal467 |
Looks like your local cypress is unable to connect to your local backend. Are you sure ur local backend is accessible in that URL? |
@rithviknishad i think this is what causing the problem i tried fixing it many times but still i am getting the same error, i tried to reinstall @types/cypress and verified type definition files but i dont understand what is causing the problem |
create a separate issue, this issue seems to be present in develop branch too. |
@rithviknishad i just want to confirm, is this issue present in the develop branch itself?and i can't clear it by fixing my tsconfig file in local? |
@NikhilGolla72 can you log in manually, and verify that you are connected to your local backend? Are you able to see the dummy data ? |
@nihal467 i am working on the care_fe repo which doesnt has any Makefile so i couldnt run the makeup command to load the dummy data but i am able to run the backend using docker desktop.Could you please tell me what is causing the error in tscong file and also in cypress attempt 2 |
Users can now upload facility cover image in the facility registration form itself.
9817d04
to
f71cfbe
Compare
Nikhil from the screenshot, you are not doing the backend configuration properly Note: CARE is not a monorepo; you can access the frontend at https://github.com/ohcnetwork/care_fe and the backend at https://github.com/ohcnetwork/care. steps to run the docker :
Once all the steps are followed properly, your backend is fully up. Connect the frontend to the backend:
|
@nihal467 Hi nihal, i am working on setup up the backend in the local, but can i know how the issue with Github actions cypress test is related to my backend setup?The change in my PR is only modifiying the Facilitycreate.tsx file and it's working fine. |
|
Users can now upload facility cover image in the facility registration form itself by enabling the checkbox option provided in the 3rd step of facility registration/
@ohcnetwork/care-fe-code-reviewers