Fixing NotificationsList on Service Worker #8686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM |
khavinshankar
requested changes
Oct 9, 2024
There was a problem hiding this comment.
@vishwansh01 the logic looks, just some suggestions on readability
| setIsSubscribed("SubscribedOnThisDevice"); | ||
| } else { | ||
| setIsSubscribed("SubscribedOnAnotherDevice"); | ||
| try { |
There was a problem hiding this comment.
we already have a try on line 223, this can be removed
Comment on lines
+247
to
+258
| if ( | ||
| navigator.serviceWorker !== null && | ||
| navigator.serviceWorker !== undefined | ||
| ) { | ||
| if ( | ||
| status === "NotSubscribed" || | ||
| status === "SubscribedOnAnotherDevice" | ||
| ) { | ||
| subscribe(); | ||
| } else { | ||
| unsubscribe(); | ||
| } |
There was a problem hiding this comment.
This is a bit hard to follow, let's re-write it
Suggested change
| if ( | |
| navigator.serviceWorker !== null && | |
| navigator.serviceWorker !== undefined | |
| ) { | |
| if ( | |
| status === "NotSubscribed" || | |
| status === "SubscribedOnAnotherDevice" | |
| ) { | |
| subscribe(); | |
| } else { | |
| unsubscribe(); | |
| } | |
| if (!navigator.serviceWorker) { | |
| return; | |
| } | |
| if (["NotSubscribed", "SubscribedOnAnotherDevice"].includes(status)) { | |
| subscribe(); | |
| } else { | |
| unsubscribe(); | |
| } |
| pf_p256dh: "", | ||
| pf_auth: "", | ||
| }; | ||
| if (reg.pushManager !== null && reg.pushManager !== undefined) { |
There was a problem hiding this comment.
same here too, let's negate the logic and return (similar to the previous comment), that makes it more readable
|
@vishwansh01 can you update the status here? |
|
Hey @bodhish, Since @vishwansh01 hasn’t responded to the requested changes on the PR, can I create a new PR for this issue if he remains inactive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist