Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card ui fix: inconsistent ui in the card #10981

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Prasanth-S7
Copy link

@Prasanth-S7 Prasanth-S7 commented Mar 3, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers
image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Style
    • Enhanced the layout of the organization view by refining spacing and element positioning. The primary container now features improved padding, and action buttons are repositioned to the bottom-right for a more organized and visually appealing interface.
    • Updated the card structure to utilize flexbox for better height management and content distribution.

@Prasanth-S7 Prasanth-S7 requested a review from a team as a code owner March 3, 2025 15:51
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 017228a
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67c68ce5648dee0008512185
😎 Deploy Preview https://deploy-preview-10981.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 3, 2025

Walkthrough

This pull request updates the OrganizationView component by restructuring and styling the Card component that displays organization details. Key changes include the addition of flexbox classes to ensure proper layout and height utilization, the repositioning of the Button component for improved accessibility, and adjustments to the rendering of the Badge component. These modifications enhance the visual layout without altering the underlying logic or data handling.

Changes

File Change Summary
src/pages/Organization/OrganizationView.tsx Updated Card component: added flex flex-col h-full; Updated CardContent: added flex-grow; Adjusted Badge rendering using getOrgLabel; Moved Button to a new div at the bottom of the Card.

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

I'm a little rabbit with coding cheer,
Hopping through styles to bring UI near.
Cards have padded steps, positioned so right,
And buttons now sit where the view feels light.
With whiskers twitching, I leap with delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bbea09 and 017228a.

📒 Files selected for processing (1)
  • src/pages/Organization/OrganizationView.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/Organization/OrganizationView.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - care-ohc
  • GitHub Check: Header rules - care-ohc
  • GitHub Check: Pages changed - care-ohc

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not use relative and bottom, instead let's keep it as the last row element and adjust accordingly; absolute and relative might break in different screen sizes and hard to make it responsive

@rithviknishad rithviknishad added invalid This doesn't seem right changes required labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI inconsistency in the card
2 participants