Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Update: Selected location not being shown for some cases #6773

Closed
rithviknishad opened this issue Dec 1, 2023 · 9 comments
Closed
Assignees
Labels
bug Something isn't working work-in-progress

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Dec 1, 2023

Describe the bug
For the particular asset, the asset location is not being shown in update asset form.

http://care.ohc.network/facility/01810c32-ec26-494a-9e65-40e5547a7746/assets/150aa43f-5fdd-43ce-ac46-df1cc32556b9

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://care.ohc.network/facility/01810c32-ec26-494a-9e65-40e5547a7746/assets/150aa43f-5fdd-43ce-ac46-df1cc32556b9
  2. Observe the location
  3. Click on update asset
  4. Observe the location in the form

Expected behavior
The already selected location must be shown

Screenshots
image

image
@rithviknishad rithviknishad added the bug Something isn't working label Dec 1, 2023
@konavivekramakrishna
Copy link
Contributor

I would like to work on it can you please assign me

@konavivekramakrishna
Copy link
Contributor

image
image

I tried to hardcode and selected the default Location 2 ID but didn't understand why it is not showing location2 Even on selecting Location 2 it's not getting selected

c3b2a9c7-dcc4-4ec0-bb08-97ab3782d311

@rithviknishad
Copy link
Member Author

Have you checked the network responses? Maybe it could be because the selected location was not able to be matched with any of the items in the response, probably because it was beyond the first page (since it's a paginated response).

If that's the case, have a look at how useAsyncOptions is used in other places for such cases (which would require LocationSelect to be refactored), or if you have other ways to merge the selected option with the response from the paginated list items.

@parthksingh1
Copy link

Hey @rithviknishad , I'm interested to work on this issue, can I please get it assigned?

@rithviknishad
Copy link
Member Author

@parthksingh1 Feel free to take this up once two of your other assigned issues are approved

@Keshav-0907
Copy link
Contributor

@rithviknishad I want to work on this issue, can you please assign this to me

@Ashutosh0602
Copy link
Contributor

@rithviknishad I was looking over this issue but I found that it is working properly on system.

This image is assets page showing location:
Screenshot 2024-02-24 at 4 42 38 AM

This image on update page showing location correctly:
Screenshot 2024-02-24 at 4 42 50 AM

@Keshav-0907
Copy link
Contributor

@rithviknishad @Ashutosh0602
Indeed, I've also thoroughly checked for all the Assets, and everything appears to be in good working order.

@rithviknishad
Copy link
Member Author

Seems to be not reproducible right now.

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work-in-progress
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants