Fixed abha linking issue #2456
Merged
Fixed abha linking issue #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2456 +/- ##
===========================================
- Coverage 64.26% 64.19% -0.07%
===========================================
Files 240 240
Lines 13549 13572 +23
Branches 1943 1950 +7
===========================================
+ Hits 8707 8713 +6
- Misses 4484 4501 +17
Partials 358 358 ☔ View full report in Codecov by Sentry. |
khavinshankar
force-pushed
the
khavinshankar-patch-1
branch
from
07a3d1a
to
348e12c
Compare
khavinshankar
changed the title
sainak
approved these changes
Sep 17, 2024
rithviknishad
approved these changes
Sep 17, 2024
|
LGTM |
anroopak
reviewed
Sep 17, 2024
| @@ -28,7 +28,7 @@ def get_object(self): | |||
| Q(abha_number=id) | Q(health_id=id) | Q(patient__external_id=id) | |||
| ).first() | |||
|
|
|||
| if not instance or get_patient_queryset(self.request.user).contains( | |||
| if not instance or not get_patient_queryset(self.request.user).contains( | |||
There was a problem hiding this comment.
Can you add a relevant test case for this change?
There was a problem hiding this comment.
Currently, we don't have any tests for ABDM, opened up an issue (ohcnetwork/care_abdm#12) to track it.
anroopak
approved these changes
Sep 17, 2024
gigincg
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins