-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Windows #820
Merged
ariasuni
merged 27 commits into
ogham:master
from
skyline75489:chesterliu/dev/win-support
Feb 20, 2023
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
7f717c3
checkpoint
zkat 6a642d0
merge
skyline75489 0e8a458
Restore
skyline75489 e9d0af0
Restore more
skyline75489 aeb4a67
It actually works
skyline75489 3158369
Timestamps
skyline75489 5503e47
Clean
skyline75489 13b3635
Fix tests
skyline75489 33dd8fd
Clean
skyline75489 e874584
Try to fix CI
skyline75489 9d61301
Git works! Hooray!
skyline75489 78a3bc9
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 00f97a9
Mimic 'Mode' in gci
skyline75489 0ea8f17
Clean
skyline75489 8ad46e2
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 0adc5c7
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 8f0e4cc
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 777cd7e
Explicitly enable vt processing on Windows
skyline75489 d6d35bf
Hide _ prefix files
skyline75489 76e336c
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 23a1c8a
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 e3204a5
Use system path sep in symlink
skyline75489 9881d00
Fix build
skyline75489 99d653b
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 d6732ae
Merge branch 'master' into chesterliu/dev/win-support
skyline75489 53cb75c
Fix build on Windows
skyline75489 6fb3740
Update src/fs/file.rs
skyline75489 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is overdoing it. Python uses
__init__.py
for top-level modules, and this hides all such files. If you're running this build with msys/cygwin, most likely your dotfiles actually start with '.' anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know any files, except for
_vimrc
on Windows that follows this convention either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even without msys/cygwin. I don't mess with those and only use pwsh, and just use the normal dot prefix for all my dotfiles (including .vimrc).