Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages for Af&Rica Android application #48

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add packages for Af&Rica Android application #48

merged 2 commits into from
Dec 18, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Dec 16, 2024

Fix offspot/package-requests#44

Adding the three languages of Af&Rica application.

Zip files created manually with custom homepage "f-droid like".

Nota: while Android package name is com.AfRica.DCX, I've chosen a slightly better ident with less risks of collision (pretty sure africa.com is not owned by Orange).

@benoit74 benoit74 self-assigned this Dec 16, 2024
@benoit74
Copy link
Contributor Author

@Popolechien can you please double check descriptions are OK?

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.01%. Comparing base (5693f09) to head (9db9b5a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   38.01%   38.01%           
=======================================
  Files          30       30           
  Lines        2291     2291           
  Branches      478      478           
=======================================
  Hits          871      871           
  Misses       1397     1397           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Popolechien
Copy link
Contributor

@benoit74 Small typo: les cultures Africaines > les cultures africaines as in French adjectives are never upper cased.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catalog entries look OK but the ZIPs are incorrect. There should be no wrapping folder.

❯ unzip -l af_and_rica_ar_1.0.0.zip
Archive:  af_and_rica_ar_1.0.0.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  12-06-2024 07:23   af_and_rica_ar/
      313  12-06-2024 07:23   __MACOSX/._af_and_rica_ar
     1714  12-16-2024 13:33   af_and_rica_ar/index.html
      269  12-16-2024 13:33   __MACOSX/af_and_rica_ar/._index.html
     6148  12-16-2024 13:30   af_and_rica_ar/.DS_Store
      120  12-16-2024 13:30   __MACOSX/af_and_rica_ar/._.DS_Store
        0  12-16-2024 13:27   af_and_rica_ar/download/
      213  12-16-2024 13:27   __MACOSX/af_and_rica_ar/._download
        0  12-06-2024 07:26   af_and_rica_ar/assets/
      213  12-06-2024 07:26   __MACOSX/af_and_rica_ar/._assets
     6148  12-16-2024 13:25   af_and_rica_ar/download/.DS_Store
      120  12-16-2024 13:25   __MACOSX/af_and_rica_ar/download/._.DS_Store
 46429593  12-16-2024 13:05   af_and_rica_ar/download/com.AfRica.DCX_1.0.0.apk
      634  12-16-2024 13:05   __MACOSX/af_and_rica_ar/download/._com.AfRica.DCX_1.0.0.apk
    16367  12-06-2024 07:22   af_and_rica_ar/assets/icon.png
      589  12-06-2024 07:22   __MACOSX/af_and_rica_ar/assets/._icon.png
     6148  12-06-2024 07:26   af_and_rica_ar/assets/.DS_Store
      120  12-06-2024 07:26   __MACOSX/af_and_rica_ar/assets/._.DS_Store
    27558  01-10-2024 11:37   af_and_rica_ar/assets/main.css
      269  01-10-2024 11:37   __MACOSX/af_and_rica_ar/assets/._main.css
    32652  01-10-2024 11:34   af_and_rica_ar/assets/roboto.ttf
      213  01-10-2024 11:34   __MACOSX/af_and_rica_ar/assets/._roboto.ttf
---------                     -------
 46529401                     22 files

❯ unzip -l com.kylecorry.trail_sense_111.zip
Archive:  com.kylecorry.trail_sense_111.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  01-10-2024 11:59   assets/
    24800  01-10-2024 11:36   assets/icon.png
    27558  01-10-2024 11:37   assets/main.css
    32652  01-10-2024 11:34   assets/roboto.ttf
        0  01-10-2024 11:42   download/
  7082356  01-10-2024 11:41   download/com.kylecorry.trail_sense_111.apk
     3321  01-10-2024 12:08   index.html
---------                     -------
  7170687                     7 files

@benoit74
Copy link
Contributor Author

And no stupid hidden __MACOSX folders ^^

@benoit74
Copy link
Contributor Author

Just made changes to the ZIM files, and obviously to the catalog since sizes / md5sum have changed

@benoit74 benoit74 requested a review from rgaudin December 17, 2024 08:46
@benoit74
Copy link
Contributor Author

I pushed some doc to https://github.com/offspot/overview/wiki/Android-App-Creation-Guide#configuration (mainly to not have to search for zip arguments again ^^)

@rgaudin
Copy link
Member

rgaudin commented Dec 18, 2024

Thank you ; I forgot to mention ZIP should not be compressed. I updated the doc, recreated the ZIPs and updated the JSON. I also added the entry to the Changelog.

@rgaudin rgaudin merged commit 6c80e3f into main Dec 18, 2024
6 checks passed
@rgaudin rgaudin deleted the af_et_rica branch December 18, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AF&Rica
3 participants