Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore if coverage report fails #209

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Ignore if coverage report fails #209

merged 1 commit into from
Feb 12, 2025

Conversation

oerc0122
Copy link
Owner

Forked repos don't necessarily have the tokens for bot.

Ignore failures on coverage reporting as not essential.

@oerc0122 oerc0122 added the testing Related to test suite. label Feb 12, 2025
@oerc0122 oerc0122 requested a review from ajjackson February 12, 2025 09:48
@oerc0122 oerc0122 self-assigned this Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2897 2667 92% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 942e575 by action🐍

@ajjackson
Copy link
Collaborator

ajjackson commented Feb 12, 2025

That's quite an interesting limitation, actually. I think this action will only work from a pull request event and can't be manually dispatched. So how would you see the coverage of an external contribution?

It's a bit surprising that it wouldn't work as the external user does have permission to comment on this repo. Would their GITHUB_TOKEN not?

@oerc0122
Copy link
Owner Author

The coverage report will be in the test report, just can't be posted to the PR without tokens it seems.

@ajjackson
Copy link
Collaborator

I see! That seems tolerable.
Screenshot 2025-02-12 at 09 58 31

@oerc0122 oerc0122 merged commit 5a13e21 into main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants