Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated outputs are invalid #17

Open
ibnesayeed opened this issue Dec 3, 2021 · 4 comments
Open

Generated outputs are invalid #17

ibnesayeed opened this issue Dec 3, 2021 · 4 comments

Comments

@ibnesayeed
Copy link
Member

The JSON and Bib files generated by the GH Workflow seem to be invalid as they contain some spurious lines for each entry.

@esavaria
Copy link
Contributor

Thank you for noticing this issue. I have removed the extra hash values to make these two formats valid. The updates will be in the next release.

@phonedude
Copy link
Member

Fixed now.

@ibnesayeed
Copy link
Member Author

Both JSON and Bib formats still seem invalid. For example, each Bib record has a trailing spurious comma (after the } of each block). Also, JSON was supposed to be an array of objects, which it is not. It seems line many independent JSON objects are concatenated, which makes the file invalid. If you want to keep them this way, then go for a format like JSONL, and serialize each record into a single line.

@phonedude phonedude reopened this Dec 22, 2021
@phonedude
Copy link
Member

ugh. you're right. will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants