Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: IGitHubClient interface does not expose the Credentials property of the underlying GitHubClient class #3000

Open
1 task done
astrohart opened this issue Feb 6, 2025 · 0 comments
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@astrohart
Copy link
Contributor

What happened?

I am programming using C# 7.3 and the .NET Framework 4.8.

Just what it says on the tin. I am trying to follow the principles of SOLID and keep a property that is of type IGitHubClient running around for accessing my GitHub client object. The Credentials property of the GitHubClient concrete class is public and I can access it, but not through my property that I've typed as of IGitHubClient, because that interface doesn't expose the Credentials property. Was this an oversight?

Versions

Octokit NuGet package v14.0.0
C# 7.3
Visual Studio 2022 Enterprise Edition v17.12.4
.NET Framework 4.8

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@astrohart astrohart added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 6, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Feb 6, 2025
@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

1 participant