Qualify pivot column name

Prevents collision with local column name, eg, pivot[sort_order] & related[sort_order]
octobercms · Nov 29, 2023 · dfcc9b2 · dfcc9b2
1 parent a67c128
commit dfcc9b2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Database/Traits/SortableRelation.php b/src/Database/Traits/SortableRelation.php
@@ -41,12 +41,14 @@ public function initializeSortableRelation()
                 return;
             }
 
+            $relation = $this->$relationName();
+
             $column = $this->getRelationSortOrderColumn($relationName);
 
-            $order = $this->$relationName()->max($column);
+            $order = $relation->max($relation->qualifyPivotColumn($column));
 
             foreach ((array) $attached as $id) {
-                $this->$relationName()->updateExistingPivot($id, [$column => ++$order]);
+                $relation->updateExistingPivot($id, [$column => ++$order]);
             }
         });
     }