Adding optional "family" string property to events. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
query-jeremy
requested review from
alanisaac,
rmouritzen-splunk and
pagbabian-splunk
pagbabian-splunk
approved these changes
Dec 11, 2024
rmouritzen-splunk
requested changes
Dec 11, 2024
There was a problem hiding this comment.
This is identical to the existing prior PR #36 -- which one do we want to keep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new
familyproperty of events to the types definition to fix a failing unrecognized key check inocsf-schema#1260.