Expand device with mobile device attributes
#1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrau-at-queryai
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber and
davemcatcisco
as code owners
floydtree
requested changes
Feb 18, 2025
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
floydtree
previously approved these changes
Feb 18, 2025
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
query-jeremy
previously approved these changes
Feb 19, 2025
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
floydtree
requested changes
Feb 20, 2025
floydtree
previously approved these changes
Feb 20, 2025
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
floydtree
approved these changes
Feb 20, 2025
query-jeremy
approved these changes
Feb 20, 2025
jonrau-at-queryai
added
enhancement
zschmerber
approved these changes
Feb 20, 2025
query-jeremy
pushed a commit
to query-ai/ocsf-schema
that referenced
this pull request
Feb 26, 2025
Currently `device` supports `imei` (deprecated) and `imei_list`. There
are several other IDs used within mobile devices that are recorded by
MDM tools such as Intune, JAMF Pro, and even CrowdStrike.
Adds `eid`, `iccid`, and `meid` to the Dictionary and to `device`.
See this example from JAMF Mobile Devices `NETWORK` attributes.
```json
"network": {
"cellularTechnology": "Unknown",
"voiceRoamingEnabled": false,
"imei": "59 105109 176278 3",
"iccid": "8991101200003204514",
"meid": "15302309236898",
"eid": "12547444452496388545569920380795",
"carrierSettingsVersion": "33.1",
"currentCarrierNetwork": "Verizon Wireless",
"currentMobileCountryCode": "311",
"currentMobileNetworkCode": "480",
"homeCarrierNetwork": "Verizon",
"homeMobileCountryCode": "US",
"homeMobileNetworkCode": "480",
"dataRoamingEnabled": true,
"roaming": false,
"personalHotspotEnabled": false,
"phoneNumber": "555-555-5555 ext 5"
},
```
Additionally, extra bools are added: `is_backed_up`,
`is_mobile_account_active`, and `is_shared` to reflect similar
attributes within JAMF Pro data, but `is_backed_up` and `is_shared` can
be re-used for other use cases.
---------
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
Co-authored-by: Rajas <89877409+floydtree@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
devicesupportsimei(deprecated) andimei_list. There are several other IDs used within mobile devices that are recorded by MDM tools such as Intune, JAMF Pro, and even CrowdStrike.Adds
eid,iccid, andmeidto the Dictionary and todevice.See this example from JAMF Mobile Devices
NETWORKattributes.Additionally, extra bools are added:
is_backed_up,is_mobile_account_active, andis_sharedto reflect similar attributes within JAMF Pro data, butis_backed_upandis_sharedcan be re-used for other use cases.