-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new attributes, objects to represent resource relationships as a graph. #1345
Conversation
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really love this. Some suggestions, clarifications.
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas <89877409+floydtree@users.noreply.github.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rajas <89877409+floydtree@users.noreply.github.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work @floydtree , this is such a great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG! 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New OCSF graph visuals going to get some frontend dev promoted..
Description of changes:
graph
object. Adding constituentnode
,edge
objects. This object is designed using existing JSON graph representation, with a few modifications to maintain consistency with OCSF.relationship_graph
of typegraph
. Adding it as anoptional
attribute ofresource_details
object.A simple exemplification of the proposed graph structure. -
The following represents relationships of an EC2 instance, which is a target resource of a particular finding. The information added via these relationships, can be considered as supplementary information about the resource itself. Note that, it's not establishing relationships amongst intra-event resources/entities. Although that's another potential use-case of this object.
The above can be simply rendered as ->
