-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand evidences
#1337
Open
jonrau-at-queryai
wants to merge
10
commits into
ocsf:main
Choose a base branch
from
jonrau-at-queryai:expand_evidences
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Expand evidences
#1337
+78
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydtree
previously requested changes
Feb 6, 2025
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
findings
Issues related to Findings Category
non_breaking
Non Breaking, backwards compatible changes
v1.5.0
Items to be considered for OCSF v1.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
Description of changes:
resource_details
toevidences
. This allows producers/mappers to account for cloud-based resources and other generic resources that does not fit well withindevice
ornetwork_endpoint
. For instance, theamazonResourceEvidence
evidence type in the Microsoft Graph Security List Alerts V2 API.name
toevidences
. In various upstream platforms such as Microsoft Graph and CrowdStrike, there are either naming conventions for the type of evidence (e.g.,amazonResourceEvidence
) or an actual display name or direct name such as thedisplay_name
value within Behaviors associated with Incidents in CrowdStrike Falcon. Microsoft Defender also has an array ofevidence
associated with their alerts that each contain theentityType
key which identities the name of the evidence.uid
toevidences
much for the same reason asname
. Platforms often have a GUID of some sort identifying the specific evidence associated with an alert such asactivity_id
associated with Crowdstrike Falcon Alerts which is the smallest "unit" of alerting/detection data. Likewise, the Behaviors associated with CrowdStrike Falcon Incidents each have their ownbehavior_id
which ties them to the Incident ID itself.verdict
andverdict_id
toevidences
to normalize similar values in other systems. In every single Evidence type within Microsoft Graph Security Alerts, there is averdict
enumeration. Likewise, Microsoft Defender for Graph Alerts haveevidence
arrays with each one containing aDetectionStatus
to denotes if something was a FP, TP, or otherwise.