Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process hOCR textangle attribute #1468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0dinD
Copy link
Contributor

@0dinD 0dinD commented Jan 31, 2025

Fixes #1467

@jbarlow83
Copy link
Collaborator

Thank you for this helpful contribution. I may need a few days to review it.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.14%. Comparing base (137b054) to head (374b76d).

Files with missing lines Patch % Lines
src/ocrmypdf/hocrtransform/_hocr.py 80.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1468      +/-   ##
==========================================
- Coverage   90.16%   90.14%   -0.02%     
==========================================
  Files          95       95              
  Lines        7128     7135       +7     
  Branches      729      730       +1     
==========================================
+ Hits         6427     6432       +5     
- Misses        496      497       +1     
- Partials      205      206       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0dinD
Copy link
Contributor Author

0dinD commented Feb 2, 2025

Thank you for this helpful contribution. I may need a few days to review it.

Yeah no worries, take your time. Let me know if there's anything on my end regarding testing and so on I should do. I'm new to this codebase and don't really know what commands to run for testing and so on. Right now I have done manual testing with some private PDFs, and also the example I created in #1467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Process hOCR textangle attribute in hOCR to PDF transform
2 participants