fix bug where custom flags have multiple=false (#414)

Co-authored-by: Mike Donnalley <mdonnalley@salesforce.com>
oclif · Jul 14, 2022 · 7337848 · 7337848
1 parent 22ced3c
commit 7337848
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/parser/flags.ts b/src/parser/flags.ts
@@ -18,7 +18,7 @@ export function build<T>(defaults: Partial<OptionFlag<T>>): Definition<T> {
       ...defaults,
       ...options,
       input: [] as string[],
-      multiple: Boolean(options.multiple),
+      multiple: Boolean(options.multiple === undefined ? defaults.multiple : options.multiple),
       type: 'option',
     } as any
   }

diff --git a/test/parser/parse.test.ts b/test/parser/parse.test.ts
@@ -327,6 +327,14 @@ See more help with --help`)
         expect(out.flags.baz.toUpperCase()).to.equal('D')
         expect(out.flags.bar.join('|')).to.equal('a|b')
       })
+      it('parses multiple flags on custom flags', async () => {
+        const out = await parse(['--foo', 'a', '--foo=b'], {
+          flags: {
+            foo: flags.option({multiple: true, parse: async i => i}),
+          },
+        })
+        expect(out.flags).to.deep.include({foo: ['a', 'b']})
+      })
     })
 
     describe('strict: false', () => {