Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add findPeer & dht refactor #793

Merged
merged 6 commits into from
Jan 13, 2025
Merged

add findPeer & dht refactor #793

merged 6 commits into from
Jan 13, 2025

Conversation

alexcos20
Copy link
Member

Changes proposed in this PR:

  • add findPeer endpoint, that returns multiaddr for a peerId (if exists in DHT)
  • refactor DHT options

@alexcos20 alexcos20 linked an issue Dec 16, 2024 that may be closed by this pull request
Add getPeer and update directCommand #792
Closed
@alexcos20 alexcos20 requested a review from paulo-ocean January 8, 2025 09:50
paulo-ocean
paulo-ocean approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20
Copy link
Member Author

looks like node image is not present anymore:
image

@alexcos20 alexcos20 merged commit c94b0dd into main Jan 13, 2025
12 checks passed
@alexcos20 alexcos20 deleted the feature/findPeer branch January 13, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getPeer and update directCommand
4 participants
@alexcos20 @jamiehewitt15 @paulo-ocean @bogdanfazakas