-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DDO: Stats and Prices for exchanges/dispensers #774
Conversation
…ed in this PR further.
For the moment only ocean-cli test regarding getDDO fails:
I'll put this in review to see if for Metadata events and Order events, I implemented as expected on the specs. |
cb9b17c
to
2cb06f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
but don't forget to update the ci.yml
after merging oceanprotocol/ocean-cli#87
with:
repository: 'oceanprotocol/ocean-cli'
path: 'ocean-cli'
ref: 'fix-tests-for-new-ddo'
put back ref: 'main'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
yep, done, merged the PR in ocean-cli, now it's updated |
Fixes #525 .
Changes proposed in this PR: