chore: bump dune version to 3.18 #11478
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Marais <dev@maiste.fr>
Signed-off-by: Etienne Marais <dev@maiste.fr>
maiste
force-pushed
the
chore/bump-dune-version
branch
from
9aa08a3 to
c909eba
Compare
rgrinberg
approved these changes
Feb 11, 2025
|
I thought it would solve the problem, but I'm not convinced because of what the CI shows. As we need |
|
Yeah, I think that's (unfortunately) probably the best way to go about it. Let's revisit this after 3.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be merged before #11275. The idea is to update the version of the dune lang first, as it implies new changes in terms of formatting. Then we can merge the PR that supports the maintenance fields on top of it.
cc @art-w