Skip to content

Commit

Permalink
Merge pull request #263 from observerly/feature/calibrator/OpenCover
Browse files Browse the repository at this point in the history 
feat: Added (c *CoverCalibrator) OpenCover().
  • Loading branch information
@michealroberts
michealroberts authored May 27, 2022
2 parents cd0cd70 + 51a1eeb commit 0c25b67
Show file tree
Hide file tree
Showing 3 changed files with 88 additions and 56 deletions.
113 changes: 57 additions & 56 deletions coverage.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
mode: atomic
github.com/observerly/alpacago/pkg/alpacago/monitor.go:10.125,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/monitor.go:27.53,29.2 1 2
github.com/observerly/alpacago/pkg/alpacago/monitor.go:38.60,49.2 3 1
github.com/observerly/alpacago/pkg/alpacago/monitor.go:57.48,59.2 1 1
github.com/observerly/alpacago/pkg/alpacago/rotator.go:10.113,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/rotator.go:28.54,39.2 3 3
github.com/observerly/alpacago/pkg/alpacago/rotator.go:47.46,49.2 1 1
Expand Down Expand Up @@ -118,7 +122,7 @@ github.com/observerly/alpacago/pkg/alpacago/alpaca.go:43.2,50.16 2 52
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:33.13,35.3 1 42
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:39.35,41.3 1 10
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:60.56,62.2 1 200
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:71.104,73.2 1 388
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:71.104,73.2 1 390
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:88.119,95.16 3 7
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:100.2,100.20 1 7
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:106.2,108.26 2 7
Expand Down Expand Up @@ -149,10 +153,10 @@ github.com/observerly/alpacago/pkg/alpacago/alpaca.go:275.2,275.20 1 2
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:281.2,283.26 2 2
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:270.16,272.3 1 0
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:275.20,278.3 2 0
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:293.119,299.16 3 188
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:304.2,304.20 1 188
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:310.2,312.29 2 188
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:316.2,318.12 2 184
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:293.119,299.16 3 190
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:304.2,304.20 1 190
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:310.2,312.29 2 190
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:316.2,318.12 2 186
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:299.16,301.3 1 0
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:304.20,307.3 2 1
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:312.29,314.3 1 4
Expand All @@ -163,59 +167,9 @@ github.com/observerly/alpacago/pkg/alpacago/alpaca.go:357.103,359.2 1 1
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:373.105,375.2 1 1
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:383.94,385.2 1 1
github.com/observerly/alpacago/pkg/alpacago/alpaca.go:393.108,395.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:10.137,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/conditions.go:27.59,29.2 1 2
github.com/observerly/alpacago/pkg/alpacago/conditions.go:38.66,49.2 3 19
github.com/observerly/alpacago/pkg/alpacago/conditions.go:57.65,59.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:67.64,69.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:77.62,79.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:87.62,89.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:97.62,99.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:107.62,109.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:117.67,119.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:127.64,129.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:137.68,139.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:147.68,149.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:157.65,159.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:169.67,171.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:179.62,181.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:189.63,191.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:199.50,208.2 3 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:216.87,224.16 4 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:229.2,229.20 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:235.2,237.26 2 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:224.16,226.3 1 0
github.com/observerly/alpacago/pkg/alpacago/conditions.go:229.20,232.3 2 0
github.com/observerly/alpacago/pkg/alpacago/conditions.go:246.90,254.16 4 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:259.2,259.20 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:265.2,267.26 2 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:254.16,256.3 1 0
github.com/observerly/alpacago/pkg/alpacago/conditions.go:259.20,262.3 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:32.63,40.2 2 1
github.com/observerly/alpacago/pkg/alpacago/discovery.go:42.120,43.30 1 6
github.com/observerly/alpacago/pkg/alpacago/discovery.go:47.2,49.35 2 6
github.com/observerly/alpacago/pkg/alpacago/discovery.go:53.2,60.16 2 6
github.com/observerly/alpacago/pkg/alpacago/discovery.go:43.30,45.3 1 2
github.com/observerly/alpacago/pkg/alpacago/discovery.go:49.35,51.3 1 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:69.46,72.16 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:76.2,78.20 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:72.16,74.3 1 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:87.53,90.16 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:94.2,94.21 1 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:90.16,92.3 1 0
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:10.121,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:28.58,39.2 3 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:47.59,49.2 1 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:57.52,59.2 1 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:67.52,69.2 1 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:77.57,87.2 3 1
github.com/observerly/alpacago/pkg/alpacago/monitor.go:10.125,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/monitor.go:27.53,29.2 1 2
github.com/observerly/alpacago/pkg/alpacago/monitor.go:38.60,49.2 3 1
github.com/observerly/alpacago/pkg/alpacago/monitor.go:57.48,59.2 1 1
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:44.129,53.2 3 5
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:61.55,63.2 1 2
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:72.62,83.2 3 8
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:72.62,83.2 3 9
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:91.60,93.2 1 1
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:102.64,105.2 2 1
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:114.64,117.2 2 1
Expand All @@ -224,6 +178,7 @@ github.com/observerly/alpacago/pkg/alpacago/calibrator.go:135.67,146.2 3 3
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:154.52,163.2 3 1
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:171.46,180.2 3 1
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:188.45,197.2 3 1
github.com/observerly/alpacago/pkg/alpacago/calibrator.go:205.45,214.2 3 1
github.com/observerly/alpacago/pkg/alpacago/camera.go:32.111,41.2 3 5
github.com/observerly/alpacago/pkg/alpacago/camera.go:49.46,51.2 1 2
github.com/observerly/alpacago/pkg/alpacago/camera.go:60.53,71.2 3 68
Expand Down Expand Up @@ -293,6 +248,52 @@ github.com/observerly/alpacago/pkg/alpacago/camera.go:823.40,832.2 3 1
github.com/observerly/alpacago/pkg/alpacago/camera.go:840.75,851.2 3 1
github.com/observerly/alpacago/pkg/alpacago/camera.go:859.68,870.2 3 1
github.com/observerly/alpacago/pkg/alpacago/camera.go:878.39,887.2 3 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:10.137,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/conditions.go:27.59,29.2 1 2
github.com/observerly/alpacago/pkg/alpacago/conditions.go:38.66,49.2 3 19
github.com/observerly/alpacago/pkg/alpacago/conditions.go:57.65,59.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:67.64,69.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:77.62,79.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:87.62,89.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:97.62,99.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:107.62,109.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:117.67,119.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:127.64,129.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:137.68,139.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:147.68,149.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:157.65,159.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:169.67,171.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:179.62,181.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:189.63,191.2 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:199.50,208.2 3 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:216.87,224.16 4 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:229.2,229.20 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:235.2,237.26 2 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:224.16,226.3 1 0
github.com/observerly/alpacago/pkg/alpacago/conditions.go:229.20,232.3 2 0
github.com/observerly/alpacago/pkg/alpacago/conditions.go:246.90,254.16 4 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:259.2,259.20 1 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:265.2,267.26 2 1
github.com/observerly/alpacago/pkg/alpacago/conditions.go:254.16,256.3 1 0
github.com/observerly/alpacago/pkg/alpacago/conditions.go:259.20,262.3 2 0
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:10.121,19.2 3 5
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:28.58,39.2 3 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:47.59,49.2 1 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:57.52,59.2 1 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:67.52,69.2 1 1
github.com/observerly/alpacago/pkg/alpacago/filterwheel.go:77.57,87.2 3 1
github.com/observerly/alpacago/pkg/alpacago/discovery.go:32.63,40.2 2 1
github.com/observerly/alpacago/pkg/alpacago/discovery.go:42.120,43.30 1 6
github.com/observerly/alpacago/pkg/alpacago/discovery.go:47.2,49.35 2 6
github.com/observerly/alpacago/pkg/alpacago/discovery.go:53.2,60.16 2 6
github.com/observerly/alpacago/pkg/alpacago/discovery.go:43.30,45.3 1 2
github.com/observerly/alpacago/pkg/alpacago/discovery.go:49.35,51.3 1 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:69.46,72.16 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:76.2,78.20 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:72.16,74.3 1 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:87.53,90.16 2 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:94.2,94.21 1 0
github.com/observerly/alpacago/pkg/alpacago/discovery.go:90.16,92.3 1 0
github.com/observerly/alpacago/pkg/alpacago/dome.go:20.107,29.2 3 5
github.com/observerly/alpacago/pkg/alpacago/dome.go:37.44,39.2 1 2
github.com/observerly/alpacago/pkg/alpacago/dome.go:48.51,59.2 3 1
Expand Down
17 changes: 17 additions & 0 deletions pkg/alpacago/calibrator.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,20 @@ func (c *CoverCalibrator) HaltCover() error {

return c.Alpaca.Put("covercalibrator", c.DeviceNumber, "haltcover", form)
}

/*
OpenCover()
@returns and error, or nil, if nil initiates cover opening if a cover is present.
@see https://ascom-standards.org/api/#/CoverCalibrator%20Specific%20Methods/put_covercalibrator__device_number__opencover
*/
func (c *CoverCalibrator) OpenCover() error {
c.Alpaca.TransactionId++

var form map[string]string = map[string]string{
"ClientID": fmt.Sprintf("%d", c.Alpaca.ClientId),
"ClientTransactionID": fmt.Sprintf("%d", c.Alpaca.TransactionId),
}

return c.Alpaca.Put("covercalibrator", c.DeviceNumber, "opencover", form)
}
14 changes: 14 additions & 0 deletions pkg/alpacago/calibrator_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -224,3 +224,17 @@ func TestNewCalibratorCoverHaltCover(t *testing.T) {
t.Errorf("got %q", calibrator.Alpaca.ErrorMessage)
}
}

func TestNewCalibratorCoverOpenCover(t *testing.T) {
calibrator.SetConnected(true)

var err = calibrator.OpenCover()

if err != nil {
t.Errorf("got %q", err)
}

if calibrator.Alpaca.ErrorNumber != 0 {
t.Errorf("got %q", calibrator.Alpaca.ErrorMessage)
}
}

0 comments on commit 0c25b67

Please sign in to comment.