Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type for Mark constructor #2229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

add type for Mark constructor #2229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/mark.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,16 @@ export interface MarkOptions {

/** The abstract base class for Mark implementations. */
export class Mark {
/**
* Constructs a new Mark object
*/
constructor(
data: any,
channels?: Record<string, Channel | ChannelValue>,
options?: MarkOptions,
defaults?: Record<string, any>
);

/**
* Renders a new plot, prepending this mark as the first element of **marks**
* of the specified *options*, and returns the corresponding SVG element, or
Expand Down