Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh-external-resources. #3146

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

gouttegd
Copy link
Collaborator

@gouttegd gouttegd commented Dec 8, 2023

This PR removes a reference to the old allen_all target, which no longer exists now that we changed the way we import the Allen ontologies. Instead, we make sure the Allen ontologies are explicitly listed in LOCAL_IMPORTS, which is used to generate the pre-requisites of the all_local_imports target. This makes the refresh-external-resources command work again.

Remove a reference to the old `allen_all` target, which no longer exists
now that we changed the way we import the Allen ontologies. Instead,
make sure the Allen ontologies are explicitly listed in `LOCAL_IMPORTS`,
which is used to generate the pre-requisites of the `all_local_imports`
target.
@gouttegd gouttegd self-assigned this Dec 8, 2023
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gouttegd gouttegd merged commit a20aa5f into master Dec 8, 2023
1 check passed
@gouttegd gouttegd deleted the fix-refresh-external-resources branch December 8, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants