Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary check for ontobot workflow #3121

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Preliminary check for ontobot workflow #3121

merged 4 commits into from
Dec 6, 2023

Conversation

hrshdhgd
Copy link
Contributor

The workflow first does a preliminary check if Hey ontobot exists in the issue body. Only if the phrase exists will the rest of the workflow run.

@hrshdhgd hrshdhgd marked this pull request as ready for review November 17, 2023 20:56
@hrshdhgd hrshdhgd requested a review from anitacaron as a code owner November 17, 2023 20:56
@hrshdhgd
Copy link
Contributor Author

@anitacaron , translating the same update for the ontobot workflow from cell-ontology to uberon.

Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update it to use the new plugin, the same as in CL? https://github.com/obophenotype/cell-ontology/blob/master/.github/workflows/ontobot.yml

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Dec 6, 2023

update it to use the new plugin

Sorry I do not follow?

@anitacaron
Copy link
Collaborator

In the CL repo, for the same workflow, you downloaded robot plugin, this part is not needed here?

https://github.com/obophenotype/cell-ontology/blob/f76d14e7e30cca21c477d91d15e2c9a46743dcd0/.github/workflows/ontobot.yml#L74-L78

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Dec 6, 2023

No. That's only if the resource is an owl file. Here the resource is an obo file so the workflow is up-to-date.

@anitacaron
Copy link
Collaborator

Ok, so because of that you also don't need to run in the container?

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Dec 6, 2023

Exactly!

@anitacaron anitacaron merged commit e059504 into master Dec 6, 2023
1 check passed
@hrshdhgd hrshdhgd deleted the ontobot-change-2 branch December 6, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants