Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3115 veins in pulmonary interlobular septum #3117

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #3115 veins in pulmonary interlobular septum
Changed venules for veins and added overlaps some 'pulmonary vein'

Fixes #3115 veins in pulmonary interlobular septum
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes noted.

Approving with the following notes:

  • There are various (and conflicting) definitions of 'pulmonary vein' within the ontology. The current text definition of 'pulmonary vein' is "Pulmonary veins are blood vessels that transport blood from the lungs to the heart[GO]." An imported external definition (AAO) is "Any of the veins which collect blood from the lungs and some small vesicles received from the esophagus.[AAO]." Another external text definition (VHOG) is "One of two pairs of large vessels that return oxygenated blood from each lung to the left atrium of the heart. [TFD][VHOG]." 'pulmonary vein' is also a child class of 'great vessel of heart'. The latter two points are not aligned with the meaning of "pulmonary veins" in the revised text definition of 'pulmonary interlobular septum'.
  • A cursory online search shows variance in the labelling of pulmonary venous vessel anatomy at this level. This reference refers to the venous vessels in the septa as "subsegmental pulmonary vein branches". The reference noted in the comment of the linked issue refers to these structures as "pulmonary vein branches", "small pulmonary veins" and "pulmonary veins".
  • Based on the above observations, it is recommended to have a SME in pulmonary vascular anatomy review the content of this and related ontology terms.

@aleixpuigb aleixpuigb merged commit 7607142 into master Nov 23, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 3115_definition_pulmonary_interlobular_septum branch November 23, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ammend definition and add axiom for 'pulmonary interlobular septum'
1 participant