Skip to content

Commit

Permalink
Fix composite unsats (#3099)
Browse files Browse the repository at this point in the history
* Remove old bogus axiom from the local CTENO mirror.

The local CTENO mirror, used to produce composite-metazoan, contains
several axioms coming from an old version of Uberon (CTENO has not been
updated since 2016). One such axiom is

'surface groove' SubClassOf: 'surface structure'

which *may* have been correct in 2016 but is clearly bogus now, since
'surface groove' (UBERON:0006846) is an immaterial anatomical entity
whereas 'surface structure' (UBERON:0003102) is an anatomical structure
(and thus a material anatomical entity).

That single axiom is causing massive unsatisfiability issues when
building composite-metazoan.

* Remove bogus axiom from the local EHDAA2 mirror.

The local EHDAA2 mirror, used to build composite-metazoan, contains the
following axiom:

'extra embryonic coelum' SubClassOf: 'attached to' some 'coelomic cavity
lumen'

This is wrong as 'attached to' (RO:0002371) is range- and
domain-restricted to anatomical structures, while both 'extra embryonic
coelum' (EHDAA2:0004739) and 'coelomic cavity lumen' (EHDAA2:0000267)
are anatomical spaces (immaterial entities).

This should really be fixed in EHDAA2, but the ontology is officially
marked as inactive and has not seen any really meaningful edit for the
past 8 years.

* Unmap 'serous sac' from EMAPA:16060 and MA:0000005.

'serous sac' (UBERON:0005906) is mapped with EMAPA:16060. This is wrong,
because the Uberon term represents an entire organ, made of a serous
membrane surrounding an anatomical cavity, while the EMAPA term refers
to a body cavity OR the lining that surrounds it. The Uberon term is
necessarily a material entity, while the EMAPA term is not committed to
being either a material entity or an immaterial entity.

Mapping the two terms together results, when building
composite-metazoan, in the EMAPA term becoming a subclass of the Uberon
term, thereby forcing the EMAPA term to be a material entity. This
causes several unsatisfiability issues because there are other Uberon
terms that are mapped to subclasses of the EMAPA term but represent
immaterial entities.

Likewise for MA:0000005.
  • Loading branch information
gouttegd authored Oct 26, 2023
1 parent 21e7141 commit 989b5a0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
6 changes: 0 additions & 6 deletions src/ontology/imports/local-cteno.owl
Original file line number Diff line number Diff line change
Expand Up @@ -12857,12 +12857,6 @@



<!-- http://purl.obolibrary.org/obo/UBERON_0006846 -->

<owl:Class rdf:about="http://purl.obolibrary.org/obo/UBERON_0006846">
<rdfs:subClassOf rdf:resource="http://purl.obolibrary.org/obo/UBERON_0003102"/>
<rdfs:label rdf:datatype="http://www.w3.org/2001/XMLSchema#string">surface groove</rdfs:label>
</owl:Class>



Expand Down
3 changes: 1 addition & 2 deletions src/ontology/imports/local-ehdaa2.owl
Original file line number Diff line number Diff line change
Expand Up @@ -25905,7 +25905,6 @@ SubClassOf(<http://purl.obolibrary.org/obo/EHDAA2_0004738> ObjectSomeValuesFrom(
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/EHDAA2_0004739> "extraembryonic coelum"^^xsd:string)
SubClassOf(<http://purl.obolibrary.org/obo/EHDAA2_0004739> <http://purl.obolibrary.org/obo/AEO_0000221>)
SubClassOf(<http://purl.obolibrary.org/obo/EHDAA2_0004739> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0001025> <http://purl.obolibrary.org/obo/EHDAA2_0000472>))
SubClassOf(<http://purl.obolibrary.org/obo/EHDAA2_0004739> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002371> <http://purl.obolibrary.org/obo/EHDAA2_0000267>))
SubClassOf(<http://purl.obolibrary.org/obo/EHDAA2_0004739> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002496> <http://purl.obolibrary.org/obo/HsapDv_0000016>))

# Class: <http://purl.obolibrary.org/obo/EHDAA2_0004740> (urogenital sinus epithelium vesical part)
Expand Down Expand Up @@ -26330,4 +26329,4 @@ AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0100001> <http://purl.ob
AnnotationAssertion(owl:deprecated <http://purl.obolibrary.org/obo/ZFA_0001690> "true"^^xsd:boolean)


)
)
2 changes: 0 additions & 2 deletions src/ontology/uberon-edit.obo
Original file line number Diff line number Diff line change
Expand Up @@ -106778,9 +106778,7 @@ id: UBERON:0005906
name: serous sac
def: "Organ with organ cavity, which has as parts a serous membrane and a serous cavity . Examples: pleural sac, pericardial sac, tendon sheath, bursa.[FMA]." [FMA:9689, https://github.com/obophenotype/uberon/issues/86]
comment: See notes for serous membrane
xref: EMAPA:16060
xref: FMA:9689
xref: MA:0000005
xref: SCTID:362890006
is_a: UBERON:0000062 ! organ
relationship: has_part UBERON:0000042 ! serous membrane
Expand Down

0 comments on commit 989b5a0

Please sign in to comment.