Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apo.obo #1

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Update apo.obo #1

merged 1 commit into from
Dec 8, 2020

Conversation

suzialeksander
Copy link
Contributor

APO:0000011 was causing issues for a user, as the old value was just null. Trying to change name to null mutant, then add null as synonym, but not sure if there should be anything in the brackets.

If this works let me know if I need to make PRs to update header date/saved-by fields.

APO:0000011 was causing issues for a user, as the old value was just `null`.  Trying to change name to `null mutant`, then add `null` as synonym, but not sure if there should be anything in the brackets...
@suzialeksander
Copy link
Contributor Author

@balhoff @cmungall tagging for review

Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe change synonym scope, if you agree.

@@ -141,6 +141,7 @@ subset: CGD
subset: CryptoGD
subset: SGD
synonym: "loss of function" RELATED [SGD:RSN]
synonym: "null" EXACT []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe be BROAD?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suzialeksander if you agree this could be BROAD (or RELATED?) let's do another little PR.

@balhoff
Copy link
Member

balhoff commented Dec 8, 2020

@suzialeksander I'm going to go ahead and merge. I also wanted to link you up with @matentzn, who is coordinating lots of phenotype ontology work (not sure if APO is already part of that).

@balhoff balhoff merged commit ae16005 into obophenotype:master Dec 8, 2020
@suzialeksander
Copy link
Contributor Author

@balhoff how long until this edit is visible on, say, ontobio (http://www.ontobee.org/ontology/APO?iri=http://purl.obolibrary.org/obo/APO_0000011) or http://ontologies.berkeleybop.org/apo.obo ? I still don't see it.

@balhoff
Copy link
Member

balhoff commented Feb 17, 2021

@cmungall @kltm is the OBO-Central obo2owl pipeline still operational? See https://github.com/OBOFoundry/OBOFoundry.github.io/blame/master/ontology/apo.md#L22-L24

@matentzn
Copy link
Contributor

No. I dont think it is - Chris is talking about reviving, but nothing concrete yet..

@balhoff
Copy link
Member

balhoff commented Feb 23, 2021

@suzialeksander I think we need to add a GitHub Actions job in this repo to create your OWL file. See OBOFoundry/OBOFoundry.github.io#1446

If @matentzn or I help you with that, it should be a good example for other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants