Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3957): Mention xcop in README #3964

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

volodya-lombrozo
Copy link
Member

Since we need xcop to be installed before building the project, we need to mention it in the docs.
Moreover, recent bugs show that we need at least 0.8.0 version of xcop to build the project.

Closes: #3957

@github-actions github-actions bot added the core label Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 155.370 167.200 11.830 7.61% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 170.034 166.835 -3.199 -1.88% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 129.141 156.270 27.129 21.01% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 11.830 ms/op (7.61%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 3.199 ms/op (1.88%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 27.129 ms/op (21.01%)

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Feb 27, 2025

@volodya-lombrozo FYI, it's not mandatory that xcop is installed on your local machine. If it's not installed - the all xcop steps are just skipped during the build. But if it's installed - it must be >= 0.8.0

@volodya-lombrozo
Copy link
Member Author

@volodya-lombrozo FYI, it's not mandatory that xcop is installed on your local machine. If it's not installed - the all xcop steps are just skipped during the build. But if it's installed - it must be >= 0.8.0

@maxonfjvipon I see, thanks. Let me fix the description then.

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Is it better now?

@maxonfjvipon
Copy link
Member

@volodya-lombrozo definitely, thanks!

@maxonfjvipon maxonfjvipon added this pull request to the merge queue Feb 27, 2025
Merged via the queue into objectionary:master with commit 1e48c05 Feb 27, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to Build the Project Due Broken jcabi-xcop Check
2 participants