Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix xcop errors #3963

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix xcop errors #3963

merged 1 commit into from
Feb 27, 2025
+4 −3

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Feb 27, 2025

No description provided.

@github-actions GitHub Actions
Copy link

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 171.303 144.607 -26.697 -15.58% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 180.921 180.425 -0.496 -0.27% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 135.646 157.485 21.839 16.10% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 26.697 ms/op (15.58%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 0.496 ms/op (0.27%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 21.839 ms/op (16.10%)

@Suban05
Copy link
Contributor Author

Suban05 commented Feb 27, 2025

@maxonfjvipon xcop checks fail in the master brach. fixed here. please take a look

@maxonfjvipon maxonfjvipon added this pull request to the merge queue Feb 27, 2025
Merged via the queue into objectionary:master with commit 7b54e6f Feb 27, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suban05 @maxonfjvipon