Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3941 move ResolveMojo tests to integration tests + divide tests into several ones #3962

Merged
merged 6 commits into from
Feb 27, 2025
Merged

#3941 move ResolveMojo tests to integration tests + divide tests into several ones #3962

merged 6 commits into from
Feb 27, 2025
+94 −37

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Feb 27, 2025

Ref: #3941

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 158.858 175.045 16.187 10.19% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 199.835 135.939 -63.896 -31.97% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 127.116 135.561 8.445 6.64% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 16.187 ms/op (10.19%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 63.896 ms/op (31.97%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 8.445 ms/op (6.64%)

@Suban05
Copy link
Contributor Author

Suban05 commented Feb 27, 2025

@maxonfjvipon please take a look

@Suban05
Copy link
Contributor Author

Suban05 commented Feb 27, 2025

@maxonfjvipon updated, please check

@maxonfjvipon maxonfjvipon added this pull request to the merge queue Feb 27, 2025
Merged via the queue into objectionary:master with commit a621694 Feb 27, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suban05 @maxonfjvipon