Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(#3946): take attribute by position #3958

Merged
merged 4 commits into from
Feb 26, 2025
Merged

bug(#3946): take attribute by position #3958

merged 4 commits into from
Feb 26, 2025
+232 −160

Conversation

maxonfjvipon
Copy link
Member

Closes: #3946

@github-actions github-actions bot added the core label Feb 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 175.547 144.788 -30.759 -17.52% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 193.419 149.175 -44.244 -22.87% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 131.723 141.862 10.139 7.70% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 30.759 ms/op (17.52%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 44.244 ms/op (22.87%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 10.139 ms/op (7.70%)

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into objectionary:master with commit 6beb471 Feb 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegor256 yegor256 yegor256 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take attributes by position in EO
2 participants
@maxonfjvipon @yegor256