Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3941 move ShakeMojo, SodgMojo tests that use Farea to integration tests #3953

Merged
merged 2 commits into from
Feb 25, 2025
Merged

#3941 move ShakeMojo, SodgMojo tests that use Farea to integration tests #3953

merged 2 commits into from
Feb 25, 2025
+122 −59

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Feb 25, 2025

Ref: #3941

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 168.705 157.776 -10.929 -6.48% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 166.743 195.161 28.417 17.04% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 132.646 155.678 23.032 17.36% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 10.929 ms/op (6.48%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 28.417 ms/op (17.04%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 23.032 ms/op (17.36%)

@Suban05
Copy link
Contributor Author

Suban05 commented Feb 25, 2025

@maxonfjvipon please take a look

@maxonfjvipon maxonfjvipon added this pull request to the merge queue Feb 25, 2025
Merged via the queue into objectionary:master with commit c0ad6af Feb 25, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suban05 @maxonfjvipon