Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3936): Add 'post-comment' Workflow #3949

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Feb 25, 2025

I added a simple workflow that runs on the master branch. Since it uses workflow_run event and runs on the master branch, GITHUB_TOKEN has read and write permissions.
This allow it to post comments to PRs.
Actually, we have only two steps here:

  • Download the message for printing.
  • Post this message to a PR.

By adding this workflow, we can provide benchmarking in a more secure environment without requiring write permissions.

Related to #3936

@github-actions github-actions bot added the core label Feb 25, 2025
@volodya-lombrozo
Copy link
Member Author

@yegor256 What do you think?

@yegor256 yegor256 enabled auto-merge February 25, 2025 08:46
@yegor256 yegor256 added this pull request to the merge queue Feb 25, 2025
@yegor256
Copy link
Member

@volodya-lombrozo let's try

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 25, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
@yegor256 yegor256 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into objectionary:master with commit e81fe61 Feb 25, 2025
23 checks passed
Copy link

github-actions bot commented Feb 25, 2025

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 166.849 162.234 -4.615 -2.77% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 178.674 141.625 -37.050 -20.74% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 162.357 149.994 -12.363 -7.61% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 4.615 ms/op (2.77%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 37.050 ms/op (20.74%)
✅ Performance gain: benchmarks.XmirBench.xmirToSaltyPhi is faster by 12.363 ms/op (7.61%)

@yegor256
Copy link
Member

@volodya-lombrozo looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants