Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3941): fixed groovy test #3942

Merged
merged 1 commit into from
Feb 23, 2025
+18 −20
Merged

bug(#3941): fixed groovy test #3942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions eo-maven-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,12 @@ SOFTWARE.
<version>1.4.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.yegor256</groupId>
<artifactId>maybeslow</artifactId>
<!-- version from parent POM -->
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down Expand Up @@ -468,10 +474,6 @@ SOFTWARE.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<skipTests>${skipITs}</skipTests>
</configuration>
<version>3.5.2</version>
<executions>
<execution>
<id>assemble-test</id>
Expand Down
6 changes: 3 additions & 3 deletions eo-maven-plugin/src/test/java/org/eolang/maven/AssembleMojoIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
*/
package org.eolang.maven;

import com.jcabi.manifests.Manifests;
import com.jcabi.manifests.Manifests;
import com.yegor256.MayBeSlow;
import com.yegor256.Mktmp;
import com.yegor256.MktmpResolver;
import com.yegor256.WeAreOnline;
Expand All @@ -43,8 +44,7 @@
* @since 0.52
*/
@SuppressWarnings({"JTCOP.RuleAllTestsHaveProductionClass", "JTCOP.RuleNotContainsTestWord"})
@ExtendWith(WeAreOnline.class)
@ExtendWith(MktmpResolver.class)
@ExtendWith({WeAreOnline.class, MktmpResolver.class, MayBeSlow.class})
final class AssembleMojoIT {

@Test
Expand Down
5 changes: 1 addition & 4 deletions eo-runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ SOFTWARE.
<groupId>io.github.artsok</groupId>
<artifactId>rerunner-jupiter</artifactId>
<version>2.1.6</version>
<scope>test</scope>
</dependency>
</dependencies>
<build>
Expand Down Expand Up @@ -281,10 +282,6 @@ SOFTWARE.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<skipTests>${skipITs}</skipTests>
</configuration>
<version>3.5.2</version>
<executions>
<execution>
<id>snippet-test</id>
Expand Down
2 changes: 1 addition & 1 deletion eo-runtime/src/test/groovy/check-runtime-deps.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ String pom = new File('pom.xml').text
GPathResult project = new XmlSlurper().parseText(pom)

project.dependencies.dependency.each { dependency ->
if (dependency.scope.text() != 'test' && dependency.scope.text() != 'provided') {
if (dependency.scope == null || (dependency.scope.text() != 'test' && dependency.scope.text() != 'provided')) {
fail(
"Dependency ${dependency.groupId.text()}.${dependency.artifactId.text()} " +
"must be in either 'test' or 'provided' scope"
Expand Down
15 changes: 7 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,13 @@ SOFTWARE.
</properties>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<skipTests>${skipITs}</skipTests>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down Expand Up @@ -472,14 +479,6 @@ SOFTWARE.
</excludes>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<!--In order to include slow tests too-->
<excludedGroups>nothing-to-exclude</excludedGroups>
</configuration>
</plugin>
<plugin>
<groupId>com.github.volodya-lombrozo</groupId>
<artifactId>jtcop-maven-plugin</artifactId>
Expand Down
Loading