Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3935): Try to Use jmh-benchmark-action #3936

Merged
merged 17 commits into from
Feb 25, 2025

Conversation

volodya-lombrozo
Copy link
Member

In this PR I've added jmh-benchmark-action to our CI/CD pipelines.

Closes: #3935.

@github-actions github-actions bot added the core label Feb 21, 2025
@volodya-lombrozo
Copy link
Member Author

volodya-lombrozo commented Feb 21, 2025

@yegor256 The "Performance Regression Check" fails, because default GITHUB_TOKEN has only read-only permissions. In other words, this action can't leave comments to the PR.
Can you generate a specific organisation token that I can use in this PR instead of GITHUB_TOKEN, please? The only permission we need is write comments to PR's.

@yegor256
Copy link
Member

@volodya-lombrozo I believe, you should create a new PAT in your GitHub account and then somehow submit it to our organization. Then, I will give this token necessary permissions.

yegor256
yegor256 previously approved these changes Feb 21, 2025
Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@volodya-lombrozo volodya-lombrozo marked this pull request as ready for review February 24, 2025 12:03
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this pull request Feb 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
Copy link

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 160.582 145.315 -15.267 -9.51% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 158.155 163.724 5.569 3.52% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 159.574 140.903 -18.671 -11.70% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 15.267 ms/op (9.51%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 5.569 ms/op (3.52%)
✅ Performance gain: benchmarks.XmirBench.xmirToSaltyPhi is faster by 18.671 ms/op (11.70%)

@volodya-lombrozo
Copy link
Member Author

@yegor256 It works, finally. Can you take a look one more time, please?

@yegor256 yegor256 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into objectionary:master with commit e269f19 Feb 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jmh-benchmark-action to Detect Performance Issues
2 participants