#3728 add @original-name attribute including parent objects
#3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon could you take a look, please? |
maxonfjvipon
requested changes
Feb 17, 2025
eo-maven-plugin/src/main/resources/org/eolang/maven/shake/set-original-names.xsl
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/resources/org/eolang/maven/shake/set-original-names.xsl
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/resources/org/eolang/maven/shake/set-original-names.xsl
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/resources/org/eolang/maven/shake/set-original-names.xsl
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/resources/org/eolang/maven/transpile/to-java.xsl
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/resources/org/eolang/maven/transpile/to-java.xsl
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/resources/org/eolang/maven/shake/set-original-names.xsl
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/ShakeMojoTest.java
Outdated
Show resolved
Hide resolved
|
@maxonfjvipon fixed, please take a look |
|
@yegor256 please check |
|
@yegor256 could you please check this one? |
yegor256
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds filling in the
original-nameattribute for objects when converting XMIR files to Java.I also made a correction to
Dataized: iforg.eolang.go.to.token.jumpis encapsulated inEOerror.ExError, then no errors are logged. For this reason, I changed the implementation of theformamethod forPhSafe. Now it returns the value from theoriginal-nameinstead of[].Closes #3728