Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the tests great again #3941

Open
maxonfjvipon opened this issue Feb 22, 2025 · 0 comments
Open

Make all the tests great again #3941

maxonfjvipon opened this issue Feb 22, 2025 · 0 comments

Comments

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Feb 22, 2025

Right now the tests in our project are not in very good condition, especially in eo-maven-plugin. There's a lot of clutter that needs to be fixed and refactored. Let's keep this ticket open until we fix all the tests in the projects.

What we want to achieve:

  1. all the tests that use Farea are moved to integration ones (we use maven-failsafe-plugin for it) since they rather slow
  2. all the integration tests are annotated with @MayBeSlow
  3. all the static literals are removed from all the tests (if it's possible)
  4. only one assert per test (yes, many tests must be divided into a several ones)
  5. assertions don't have hard-coded expected values and magic numbers/strings (if it's possible). Let's use variables for it. Instead of Matchers.equalTo(5) let's do int expected = 5; Matchers.equalTo(expected). Also it would good to use the variable in assertion message where they're explained
  6. all the test have assertion messages
  7. each test has different input
  8. to be continued...Please don't make a huge PRs. Micro changes are very welcome!
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Feb 22, 2025
yegor256 added a commit that referenced this issue Feb 23, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 24, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 24, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 24, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 24, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 24, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 24, 2025
#3941 move `LintMojo` tests that use `Farea` to integration tests
Suban05 added a commit to Suban05/eo that referenced this issue Feb 25, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 25, 2025
#3941 move `ParseMojo`, `PrintMojo` tests that use `Farea` to integration tests
Suban05 added a commit to Suban05/eo that referenced this issue Feb 25, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 25, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 25, 2025
#3941 move `ShakeMojo`, `SodgMojo` tests that use `Farea` to integration tests
Suban05 added a commit to Suban05/eo that referenced this issue Feb 27, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 27, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 27, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 27, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 27, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2025
#3941 move `ResolveMojo` tests to integration tests + divide tests into several ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant