Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<license/> in XMIR should have SPDX format, instead of raw text #3934

Closed
h1alexbel opened this issue Feb 20, 2025 · 4 comments · Fixed by #3959
Closed

<license/> in XMIR should have SPDX format, instead of raw text #3934

h1alexbel opened this issue Feb 20, 2025 · 4 comments · Fixed by #3959
Assignees

Comments

@h1alexbel
Copy link
Contributor

h1alexbel commented Feb 20, 2025

Currently, we put the whole license text inside <license/>. Instead, we should parse it like this:

<program>
  <license name="MIT">2023-2025 Yegor Bugayenko</license>
</program>

This way it would be compliant with SPDX

This message motivates this issue.

@h1alexbel
Copy link
Contributor Author

@maxonfjvipon Assign me, please

@yegor256
Copy link
Member

yegor256 commented Feb 20, 2025

@h1alexbel I suggest we get rid of the license entirely in EO syntax, and move this info into the meta section:

+copy SPDX-FileCopyrightText 2023-2025 Yegor Bugayenko
+copy SPDX-License-Identifier MIT

# No comments.
[] > foo

Everything that goes after +spdx turns into SPDX compliant directives:

# SPDX-FileCopyrightText: 2023-2025 Yegor Bugayenko
# SPDX-License-Identifier: MIT

In other words, no more "license" that may start a .eo file.

@h1alexbel
Copy link
Contributor Author

h1alexbel commented Feb 20, 2025

@yegor256 I like it. @maxonfjvipon ^ WDYT? (please assign me, if you like the idea)

h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
h1alexbel added a commit to h1alexbel/eo that referenced this issue Feb 26, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2025
feat(#3934): `spdx` meta instead of `<license/>` node
@0pdd
Copy link

0pdd commented Feb 27, 2025

@h1alexbel the puzzle #3965 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants