Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@original-name doesn't include parent objects #3728

Closed
yegor256 opened this issue Dec 22, 2024 · 8 comments · Fixed by #3920
Closed

@original-name doesn't include parent objects #3728

yegor256 opened this issue Dec 22, 2024 · 8 comments · Fixed by #3920
Assignees

Comments

@yegor256
Copy link
Member

yegor256 commented Dec 22, 2024

In .xmir files, for example in go.xmir that stays in the eo-runtime/target/eo/8-transpile/org/eolang/ directory, there is this object:

<class ancestors="3"
             java-name="EOorg.EOeolang.EOgo$EOto$EOtoken$EOjump"
             line="75"
             loc="Φ.org.eolang.go$to$token$jump"
             name="go$to$token$jump"
             original-name="jump"
             package="org.eolang"
             parent="go$to$token"
             pos="6">

Obviously, the @original-name is set wrong. Should be: go.to.token.jump, while it has
just jump.

When this is fixed, let's fix Dataized too: it must not log errors if org.eolang.go.to.token.jump is encapsulated in the instance of EOerror.ExError that is caught.

@Suban05
Copy link
Contributor

Suban05 commented Feb 10, 2025

@yegor256 may I try this one?

@yegor256
Copy link
Member Author

@Suban05 sure, you can try!

@Suban05
Copy link
Contributor

Suban05 commented Feb 10, 2025

@yegor256 @maxonfjvipon Could you please explain how I can get this result

<class ancestors="3"
             java-name="EOorg.EOeolang.EOgo$EOto$EOtoken$EOjump"
             line="75"
             loc="Φ.org.eolang.go$to$token$jump"
             name="go$to$token$jump"
             original-name="jump"
             package="org.eolang"
             parent="go$to$token"
             pos="6">

I've checked the file eo-runtime/target/eo/8-transpile/org/eolang/go.xmir, but I see that there is no information about the original-name. I see only this information, probably related to this ticket:

&lt;o line="75" loc="Φ.org.eolang.go.to.token.jump" name="jump" pos="6"&gt;

@maxonfjvipon
Copy link
Member

@yegor256 it seems the attribute @original-name was removed from transpile transformations, maybe by mistake. What was the original intense of the attribute?

@yegor256
Copy link
Member Author

@maxonfjvipon it should be the FQN of EO object

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Feb 11, 2025

@yegor256 isn't @loc suitable for this? Looks like it's the same

@yegor256
Copy link
Member Author

@maxonfjvipon well, it has the same meaning, but it's not the same. It's better to keep the original name intact. It may help us in the future, to trace bugs.

@maxonfjvipon
Copy link
Member

@Suban05 as you may see - your task came down to adding @original-name attribute while converting XMIR to Java. And here you can do it in the right way - add FQN instead of just last part

Suban05 added a commit to Suban05/eo that referenced this issue Feb 12, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 12, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 13, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 18, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 18, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 18, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 18, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 18, 2025
Suban05 added a commit to Suban05/eo that referenced this issue Feb 18, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
#3728 add `@original-name` attribute including parent objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants