Skip to content

Commit

Permalink
update electron builder config
Browse files Browse the repository at this point in the history
  • Loading branch information
hristoiankov committed Jan 13, 2025
1 parent 25bc875 commit 2f36be7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/angular-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [21.x]
node-version: [22.x]
defaults:
run:
working-directory: ./cider-app
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/electron-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
node-version: [21.x]
node-version: [22.x]
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_TOKEN }}
defaults:
Expand All @@ -26,9 +26,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Install Snapcraft
uses: oatear/action-snapcraft@v1
if: startsWith(matrix.os, 'ubuntu')
# - name: Install Snapcraft
# uses: oatear/action-snapcraft@v1
# if: startsWith(matrix.os, 'ubuntu')

- name: Build/release Electron app
uses: oatear/action-electron-builder@v1.0.1
Expand Down
15 changes: 6 additions & 9 deletions cider-app/electron-builder.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,15 @@
}
],
"mac": {
"icon": "dist/cider/assets/cider-logo.icns"
"icon": "dist/cider/assets/cider-logo.icns",
"target": ["dmg"]
},
"win": {
"icon": "dist/cider/favicon.ico"
"icon": "dist/cider/favicon.ico",
"target": ["msi"]
},
"linux": {
"icon": "dist/cider/assets/cider-logo.icns"
},
"snap": {
"publish": {
"provider": "generic",
"url": "https://disable.snapcraft"
}
"icon": "dist/cider/assets/cider-logo.icns",
"target": ["deb"]
}
}

0 comments on commit 2f36be7

Please sign in to comment.