indexer: Fix block cache pruning #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/reduce-allocs
branch
2 times, most recently
from
77b9e25 to
26b790c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 61.86% 62.33% +0.46%
==========================================
Files 37 37
Lines 3920 3921 +1
==========================================
+ Hits 2425 2444 +19
+ Misses 1288 1272 -16
+ Partials 207 205 -2 ☔ View full report in Codecov by Sentry. |
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/reduce-allocs
branch
2 times, most recently
from
1c56354 to
7f8d027
Compare
Block was never pruned from the `blockDataByNumber` cache.
ptrus
force-pushed
the
ptrus/feature/reduce-allocs
branch
from
7f8d027 to
66a796d
Compare
kostko
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block was never pruned from the
blockDataByNumbercache so the cache kept growing indefinitely.Also reduce the duplicate to-hex conversions in block indexing.