Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build oasis-node and oasis-net-runner from source #485

Closed
wants to merge 1 commit into from

Conversation

CedarMist
Copy link
Member

@abukosek if you're interested, this change builds oasis-core from source rather than pulling from github releases

I think we should have the option to build Sapphire paratime binary from source too as it will make testing changes quicker.

However, I think there should probably be two modes:

  • release mode - uses files downloaded from github releases
  • dev mode - builds everything from source

Will investigate if this is possible.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.86%. Comparing base (aa3c5a1) to head (588503f).
Report is 182 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          37       37           
  Lines        3920     3920           
=======================================
  Hits         2425     2425           
  Misses       1288     1288           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abukosek
Copy link
Contributor

abukosek commented Nov 30, 2023

Cool!
Yeah, I also think there should be two separate modes for this. The simplest way to do this would be to add another ENV var and then conditionally build from source or download existing artifacts based on that (or even better, an ARG, which we could then specify when building the image with --build-arg).

@matevz
Copy link
Member

matevz commented Sep 11, 2024

Superseeded by #601

@matevz matevz closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants