Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix running start.sh without a terminal #484

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

abukosek
Copy link
Contributor

No description provided.

@CedarMist CedarMist self-requested a review November 29, 2023 11:39
@CedarMist CedarMist added bug Something isn't working p:0 Priority: High! bugs, address immediately docker Docker related issues labels Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (132009d) 61.86% compared to head (7766cab) 61.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          37       37           
  Lines        3920     3920           
=======================================
  Hits         2425     2425           
  Misses       1288     1288           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally without the Docker -t option and it runs fine without a tty.

This will fix CI tests on sapphire-paratime

@abukosek abukosek merged commit aa3c5a1 into main Nov 29, 2023
8 checks passed
@abukosek abukosek deleted the andrej/fix/improve-test branch November 29, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker Docker related issues p:0 Priority: High! bugs, address immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants