Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Bump sapphire 0.7.0-testnet and emerald 11.0.0-testnet #467

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 20, 2023

This PR bumps the runtimes used in the docker images:

  • Sapphire ParaTime to 0.7.0-testnet
  • Emerald ParaTime to 11.0.0-testnet
  • oasis-core-dev to the new 23.0.x branch living on ghcr.io
  • simple-keymanager to the new stable/23.0.x branch

Also fixes the default deposit amount mentioned in README to 10,000 TEST as it should be from the beginning (compatible with the Hardhat's node).

Followup to #460

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #467 (0fe3c46) into main (62dd6e1) will increase coverage by 2.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   59.33%   62.13%   +2.79%     
==========================================
  Files          37       37              
  Lines        3903     3903              
==========================================
+ Hits         2316     2425     +109     
+ Misses       1396     1271     -125     
- Partials      191      207      +16     

see 5 files with indirect coverage changes

@matevz matevz force-pushed the matevz/docker/sapphire-0.7.0-testnet branch 3 times, most recently from d4e1451 to 84e3810 Compare October 20, 2023 18:48
@matevz matevz marked this pull request as ready for review October 20, 2023 18:50
@matevz matevz requested review from kostko and ptrus as code owners October 20, 2023 18:50
@matevz matevz requested review from CedarMist and ptrus and removed request for kostko and ptrus October 20, 2023 18:50
@matevz matevz force-pushed the matevz/docker/sapphire-0.7.0-testnet branch 5 times, most recently from 392d305 to eca3db6 Compare October 23, 2023 15:35
@matevz matevz force-pushed the matevz/docker/sapphire-0.7.0-testnet branch from eca3db6 to 0fe3c46 Compare October 23, 2023 16:50
@matevz matevz merged commit ec2814a into main Oct 23, 2023
5 of 6 checks passed
@matevz matevz deleted the matevz/docker/sapphire-0.7.0-testnet branch October 23, 2023 21:08
@CedarMist
Copy link
Member

CedarMist commented Oct 24, 2023

This has borked sapphire-dev

Have to run sapphire-dev with -e SAPPHIRE_BACKEND=internal to avoid using the mock backend for it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants