Block confirming dangerous actions

[lukaw3d]

Related to #243

Disables Confirm button in #236 for the following warnings:

• confirmTransferringToValidator
• confirmDepositingToParatimeToForeignAccount (except in Emerald paratime)
• confirmWithdrawingFromParatimeToForeignAccount
• confirmDepositingToParatimeToLedgerAccount

Related to oasisprotocol/wallet@699336f

[pro-wh]

didn't understand what I read, but it looks pretty unthreatening of an implementation.

other than the implementation, we discussed in some brief meetings that the team wants to move the extension in this direction. so it is on behalf of our whole team that I formally enter this change as approved.

[pro-wh]

what does this part do? I don't know react.

getting rid of click-cursor? two-arg cx to three-arg cx? what is cx?

[lukaw3d]

https://www.npmjs.com/package/classnames

classNames('foo', { bar: true, duck: false }, 'baz', { quux: true }); // => 'foo bar baz quux'
classNames(null, false, 'bar', undefined, 0, 1, { baz: null }, ''); // => 'bar 1'

In case of our disabled button:

• original

  cx("click-cursor", {
    "common-button": true, 
    ["account-common-btn account-common-btn-danger"]: true, 
    "click-cursor": false, 
    "click-cursor-disable": true,
  })
  // => "click-cursor common-button account-common-btn account-common-btn-danger click-cursor-disable"

• removed needless unconditional click-cursor. CSS context

  .click-cursor { cursor: pointer; }
  .click-cursor-disable { cursor: not-allowed; }

  cx({
    "common-button": true, 
    ["account-common-btn account-common-btn-danger"]: true, 
    "click-cursor": false, 
    "click-cursor-disable": true,
  })
  // => "common-button account-common-btn account-common-btn-danger click-cursor-disable"

• used unconditional classes like a normal person (and typescript didn't like newly-typed propsClass: string | undefined as an object key)

  cx("common-button", "account-common-btn account-common-btn-danger", {
    "click-cursor": false, 
    "click-cursor-disable": true,
  })
  // => "common-button account-common-btn account-common-btn-danger click-cursor-disable"

[pro-wh]

ok yeah that old one was really weird. probably written without an understanding of cx.

[pro-wh]

why did we get rid of it? this PR adds no new references to this. were there broken references before this?

[lukaw3d]

#239 (comment)
had broken reference after we removed this warning from emerald. I didn't notice it was still used for cipher

[pro-wh]

ℹ️ moved unchanged

[lukaw3d]

All four warnings are now neatly together in the translation :D

[pro-wh]

users who must still do these non-recommended transactions using this software: for the time being, un-disable the button in the dev tools. in the longer term, migrate to using the CLI for these "I know what I'm doing" actions

[lukaw3d]

hmm, removing this in devtools doesn't fix click

[pro-wh]

how does disabled work in the Button component?

[pro-wh]

oh it goes into <button disabled={disabled}>

[lukaw3d]

Button just forwards it to button, then react does a lot of magic that I don't know.
Either react doesn't attach the listener when it creates a disabled button, or it ignores events based on internal props without looking at changed html.

But this is probably involved https://github.com/facebook/react/blob/9abe745/packages/react-dom/src/events/getListener.js#L40