Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/ts-web: bump @types/elliptic from 6.4.14 to 6.4.18 in /client-sdk/ts-web #1562

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2023

Bumps @types/elliptic from 6.4.14 to 6.4.18.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @pro-wh.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from kostko, pro-wh and ptrus as code owners November 21, 2023 01:29
@dependabot dependabot bot added the c:client-sdk/typescript Category: TypeScript client SDK label Nov 21, 2023
@dependabot dependabot bot requested a review from peternose as a code owner November 21, 2023 01:29
@dependabot dependabot bot added the c:deps Category: external dependencies label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5907b60) 60.41% compared to head (121a3d9) 60.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files         139      139           
  Lines        9949     9949           
=======================================
  Hits         6011     6011           
  Misses       3896     3896           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/types/elliptic-6.4.18 branch from 5d28f22 to 1378e19 Compare December 7, 2023 13:51
Bumps [@types/elliptic](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/elliptic) from 6.4.14 to 6.4.18.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/elliptic)

---
updated-dependencies:
- dependency-name: "@types/elliptic"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/types/elliptic-6.4.18 branch from 1378e19 to da6fe36 Compare December 7, 2023 19:39
@pro-wh
Copy link
Contributor

pro-wh commented Dec 7, 2023

huh, I didn't realize they added Uint8Arrray to BNInput. let's remove some unnecessary Array.from

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver suggests this should be safe, and tests haven't picked up any breakages

@dependabot merge

@dependabot dependabot bot merged commit 0d0435e into main Dec 7, 2023
28 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/client-sdk/ts-web/types/elliptic-6.4.18 branch December 7, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:client-sdk/typescript Category: TypeScript client SDK c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant