Skip to content

Commit

Permalink
Include metadata_registry in the E2E regression tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ptrus committed Jan 18, 2025
1 parent 0ef5fe5 commit fd6b41c
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 10 deletions.
15 changes: 9 additions & 6 deletions analyzer/metadata_registry/metadata_registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,31 +32,34 @@ const MetadataRegistryAnalyzerName = "metadata_registry"
type processor struct {
target storage.TargetStorage
logger *log.Logger

regCfg registry.GitConfig
}

var _ item.ItemProcessor[struct{}] = (*processor)(nil)

func NewAnalyzer(
cfg config.ItemBasedAnalyzerConfig,
cfg config.MetadataRegistryConfig,
target storage.TargetStorage,
logger *log.Logger,
) (analyzer.Analyzer, error) {
logger.Info("Starting metadata_registry analyzer")
if cfg.Interval == 0 {
cfg.Interval = 2 * time.Minute
}
if cfg.Interval < time.Minute {
return nil, fmt.Errorf("invalid interval %s, metadata registry interval must be at least 1 minute", cfg.Interval)
}
logger = logger.With("analyzer", MetadataRegistryAnalyzerName)
p := &processor{
target: target,
logger: logger,
regCfg: registry.NewGitConfig(),
}
if cfg.RepositoryBranch != "" {
p.regCfg.Branch = cfg.RepositoryBranch
}

return item.NewAnalyzer[struct{}](
MetadataRegistryAnalyzerName,
cfg,
cfg.ItemBasedAnalyzerConfig,
p,
target,
logger,
Expand All @@ -68,7 +71,7 @@ func (p *processor) GetItems(ctx context.Context, limit uint64) ([]struct{}, err
}

func (p *processor) ProcessItem(ctx context.Context, batch *storage.QueryBatch, item struct{}) error {
gp, err := registry.NewGitProvider(registry.NewGitConfig())
gp, err := registry.NewGitProvider(p.regCfg)
if err != nil {
return fmt.Errorf("failed to create Git registry provider: %s", err)
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/analyzer/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ func NewService(cfg *config.AnalysisConfig) (*Service, error) { //nolint:gocyclo
}
if cfg.Analyzers.MetadataRegistry != nil {
analyzers, err = addAnalyzer(analyzers, err, "" /*syncTag*/, func() (A, error) {
return metadata_registry.NewAnalyzer(cfg.Analyzers.MetadataRegistry.ItemBasedAnalyzerConfig, dbClient, logger)
return metadata_registry.NewAnalyzer(*cfg.Analyzers.MetadataRegistry, dbClient, logger)
})
}
if cfg.Analyzers.ValidatorStakingHistory != nil {
Expand Down
5 changes: 2 additions & 3 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -523,13 +523,12 @@ type EvmAbiAnalyzerConfig struct {
// MetadataRegistryConfig is the configuration for the metadata registry analyzer.
type MetadataRegistryConfig struct {
ItemBasedAnalyzerConfig `koanf:",squash"`

RepositoryBranch string `koanf:"repository_branch"`
}

// Validate validates the configuration.
func (cfg *MetadataRegistryConfig) Validate() error {
if cfg.Interval < time.Minute {
return fmt.Errorf("metadata registry interval must be at least 1 minute")
}
return nil
}

Expand Down
Empty file.
Empty file.

0 comments on commit fd6b41c

Please sign in to comment.