Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix common.sh No such file or directory #45

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix common.sh No such file or directory #45

merged 1 commit into from
Mar 7, 2024

Conversation

effoeffi
Copy link
Contributor

@effoeffi effoeffi commented Mar 7, 2024

No description provided.

@effoeffi effoeffi mentioned this pull request Mar 7, 2024
@g-getsov
Copy link
Contributor

g-getsov commented Mar 7, 2024

@effoeffi Looks good, lets merge for people who are running of latest. I'll take a look at whats happening but its probably the files missing from the Docker container like you said. Should be a very easy fix to copy in the common folder. Would be good to have that for DRY reasons.

Apologies for missing this.

@effoeffi effoeffi merged commit 205ce7e into main Mar 7, 2024
16 checks passed
@effoeffi effoeffi deleted the fix_common branch March 7, 2024 18:57
@g-getsov
Copy link
Contributor

g-getsov commented Mar 7, 2024

@effoeffi It seems that files in directories above the root directory of the selected action are disappointingly NOT cloned, which makes reusing code non trivial as its not there to be copied into the docker container. It's probably not worth pursuing any of the more complex solutions at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants