Add session and sprint UUID fields to fires #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jan 29, 2025
| sprint_uuid = models.UUIDField(null=True) | ||
|
|
||
| # TODO remove | ||
| extra = models.JSONField(null=True) |
There was a problem hiding this comment.
maybe I was trying to be too generic..
rowanseymour
commented
Jan 29, 2025
| fire_on = models.DateTimeField(db_index=True) | ||
|
|
||
| # used to ensure wait events don't act on a session that's already changed | ||
| session_uuid = models.UUIDField(null=True) | ||
| sprint_uuid = models.UUIDField(null=True) |
There was a problem hiding this comment.
no foreign keys.. don't want the index overhead and thinking ahead to when sessions might not be in the database at all
rowanseymour
force-pushed
the
contact_fire_session_and_sprint_uuids
branch
from
09ccaf6 to
d463187
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5832 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 463 465 +2
Lines 25178 25189 +11
=========================================
+ Hits 25178 25189 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.