Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues with LLM example documentation #1992

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 25, 2024

Description

  • Agents: Show an actual runnable command that can be copy/pasted, not just the command usage.
  • Completion: Remove blank line in command block
  • RAG: Remove section about fetching data, RAG doesn't need any LFS files.
  • VDB Upload: Pipeline requires the examples dataset not the datasets dataset.
  • VDB Upload: Document how to run Milvus

Closes #1991

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Oct 25, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 25, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners October 25, 2024 15:21
@dagardner-nv dagardner-nv changed the base branch from branch-25.02 to branch-24.10 October 25, 2024 15:50
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 13c7268 into nv-morpheus:branch-24.10 Oct 25, 2024
12 of 13 checks passed
@dagardner-nv dagardner-nv deleted the david-fix-llm-docs-1991 branch October 25, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants